Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding emergency registration procedure #1060

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kbaccar
Copy link

@kbaccar kbaccar commented Dec 16, 2022

  • Added IMEI based emergency registration for srsUE
  • Added a new parameter nas.enable_emergency_reg (default = false)

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@andrepuschmann andrepuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for your contribution. I have a few comments, see below. You definitely should check your clang-format config. Thanks

srsue/hdr/stack/upper/nas_config.h Outdated Show resolved Hide resolved
srsue/src/stack/upper/nas_5g.cc Outdated Show resolved Hide resolved
srsue/src/stack/upper/nas_5g.cc Outdated Show resolved Hide resolved
srsue/src/stack/upper/nas_5g.cc Show resolved Hide resolved
srsue/src/stack/upper/nas_5g_procedures.cc Show resolved Hide resolved
@andrepuschmann
Copy link
Collaborator

Hey @kbaccar, thanks for the PR again. We'll release the 23.04 version of srsRAN 4G in a few days that will include a few changes in the files your PR touched. Would be good if you could rebase your PR on top of it once it's out.

@kbaccar
Copy link
Author

kbaccar commented May 23, 2023

@andrepuschmann Conflict fixed, branch have been merged to master.

@kbaccar kbaccar requested a review from andrepuschmann October 3, 2023 11:12
@kbaccar
Copy link
Author

kbaccar commented Aug 25, 2024

@andrepuschmann branch merged with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants